updating business patterns and LODES scripts#53
Merged
wcurrangroome merged 5 commits intomainfrom Feb 3, 2026
Merged
Conversation
wcurrangroome
requested changes
Oct 21, 2025
Collaborator
wcurrangroome
left a comment
wcurrangroome
left a comment
There was a problem hiding this comment.
For both datasets:
- Can you add a
@detailschunk to the Roxygen documentation clarifying what the data represent, what they can be used for, their limitations, how they differ from LEHD/LODES, etc.? - Can you add details about the fields that are included in the returned dataframe as part of the roxygen documentation? Refer to get_public_assistance.R for an example: https://github.com/UI-Research/climateapi/blob/main/R/get_public_assistance.R
- Can you build out a corresponding test file that encompasses testable assertions about how each function should behave? I creates these files (no contents yet) in /tests/testthat. Check out https://r-pkgs.org/testing-basics.html for an introduction to the approach. Some good things to test for include: valid responses for valid combinations of parameters; clear errors for invalid parameters; missingness levels for returned data; the absence of any values that are infeasible (e.g., negative counts, percentages greater than 100%, etc.).
Collaborator
|
Also, the base get_business_pattern() function was working but is now throwing an error... I'm wondering if it's an issue with the Census API (hopefully short-lived)? Else I might have accidentally altered something in the code (sorry if so). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updating business patterns script to include the selected naics codes and year and ignore some of the higher codes that do not have any associated data.
updating the LODES script to properly join data based on whether it is "wac", "rac", or "od" data being requested